feat #14740: transcription model choice, vocabulary and short-word corrections
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
@@ -6,6 +6,7 @@ use std::collections::BTreeMap;
|
||||
use chrono::{DateTime, Local};
|
||||
use serde::Serialize;
|
||||
|
||||
use crate::corrections::correct_segment_text;
|
||||
use crate::merge;
|
||||
use crate::model::{Call, CallId, CallStatus, Segment, Speaker};
|
||||
|
||||
@@ -176,13 +177,18 @@ pub struct CallDetail {
|
||||
impl CallDetail {
|
||||
/// `segments` are the stored ones; `merges` the stored speaker merges
|
||||
/// (source key → target key); `backend_url` is this build's backend
|
||||
/// (see [`CallListItem::of`]).
|
||||
/// (see [`CallListItem::of`]); `language` is the call-language setting
|
||||
/// in effect now (not necessarily what the call was transcribed with),
|
||||
/// used to apply [`correct_segment_text`] to each segment's text —
|
||||
/// non-destructively, so it also corrects transcripts from before the
|
||||
/// correction existed.
|
||||
pub fn of(
|
||||
call: &Call,
|
||||
segments: &[Segment],
|
||||
speaker_names: BTreeMap<String, String>,
|
||||
merges: &BTreeMap<String, String>,
|
||||
backend_url: &str,
|
||||
language: &str,
|
||||
) -> Self {
|
||||
let segments = merge::apply_merges(segments, merges)
|
||||
.iter()
|
||||
@@ -191,7 +197,7 @@ impl CallDetail {
|
||||
label: merge::label(&segment.speaker, &speaker_names),
|
||||
start: segment.start,
|
||||
end: segment.end,
|
||||
text: segment.text.clone(),
|
||||
text: correct_segment_text(&segment.text, language),
|
||||
})
|
||||
.collect();
|
||||
Self {
|
||||
@@ -500,6 +506,7 @@ mod tests {
|
||||
names.clone(),
|
||||
&BTreeMap::new(),
|
||||
BACKEND,
|
||||
"de",
|
||||
);
|
||||
|
||||
let lines: Vec<_> = detail
|
||||
@@ -550,6 +557,7 @@ mod tests {
|
||||
names,
|
||||
&merges,
|
||||
BACKEND,
|
||||
"de",
|
||||
);
|
||||
|
||||
let lines: Vec<_> = detail
|
||||
@@ -601,9 +609,15 @@ mod tests {
|
||||
c.transcribed_at = Some(at(10, 20, 0));
|
||||
let merges = keys(&[("remote:2", "remote:1")]);
|
||||
|
||||
let value =
|
||||
serde_json::to_value(CallDetail::of(&c, &[], BTreeMap::new(), &merges, BACKEND))
|
||||
.unwrap();
|
||||
let value = serde_json::to_value(CallDetail::of(
|
||||
&c,
|
||||
&[],
|
||||
BTreeMap::new(),
|
||||
&merges,
|
||||
BACKEND,
|
||||
"de",
|
||||
))
|
||||
.unwrap();
|
||||
|
||||
assert_eq!(
|
||||
value,
|
||||
@@ -637,12 +651,22 @@ mod tests {
|
||||
}
|
||||
|
||||
fn detail_with(c: &Call, segments: &[Segment], names: &[(&str, &str)]) -> CallDetail {
|
||||
detail_with_language(c, segments, names, "de")
|
||||
}
|
||||
|
||||
fn detail_with_language(
|
||||
c: &Call,
|
||||
segments: &[Segment],
|
||||
names: &[(&str, &str)],
|
||||
language: &str,
|
||||
) -> CallDetail {
|
||||
CallDetail::of(
|
||||
c,
|
||||
segments,
|
||||
keys(names),
|
||||
&keys(&[("remote:2", "remote:1")]),
|
||||
BACKEND,
|
||||
language,
|
||||
)
|
||||
}
|
||||
|
||||
@@ -704,4 +728,39 @@ mod tests {
|
||||
}
|
||||
assert_eq!(NO_TRANSCRIPT, "Kein Transkript zum Hochladen");
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn a_whole_segment_mistranscribed_as_english_is_corrected_in_the_detail_view() {
|
||||
let c = call(Some(at(10, 15, 0)));
|
||||
let segments = [
|
||||
segment(Speaker::Me, 0.0, "Cheers!"),
|
||||
segment(Speaker::Remote(3), 3.0, "Perfect."),
|
||||
segment(Speaker::Remote(1), 6.0, "Cheers, see you later."),
|
||||
];
|
||||
|
||||
let detail = detail_with(&c, &segments, &[]);
|
||||
|
||||
let texts: Vec<_> = detail.segments.iter().map(|s| s.text.as_str()).collect();
|
||||
assert_eq!(texts, ["Tschüss!", "Perfekt.", "Cheers, see you later."]);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn corrections_are_not_applied_outside_german_calls() {
|
||||
let c = call(Some(at(10, 15, 0)));
|
||||
let segments = [segment(Speaker::Me, 0.0, "Cheers!")];
|
||||
|
||||
let detail = detail_with_language(&c, &segments, &[], "en");
|
||||
|
||||
assert_eq!(detail.segments[0].text, "Cheers!");
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn the_upload_text_uses_the_corrected_segment_text() {
|
||||
let c = call(Some(at(10, 46, 0)));
|
||||
let segments = [segment(Speaker::Me, 0.0, "Cheers!")];
|
||||
|
||||
let text = detail_with(&c, &segments, &[]).upload_text().unwrap();
|
||||
|
||||
assert!(text.ends_with("Ich: Tschüss!"), "upload text was: {text}");
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user